Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dev test #8

wants to merge 4 commits into from

Conversation

HBinmore
Copy link

The following features have been added:

  • Customers Page

    • The ability to create new customers, providing a Name and Type
    • The ability to view a list of all existing customers
    • The ability to view the details of a specific customer
  • Jobs Page

    • Jobs can now be assigned to a customer upon creation
      • This is a required field for all new jobs
    • In the jobs list, the assigned customer name is displayed (if present)
    • In job details, the assigned customer name and customer type are displayed (if present)

Hypothetical future expansion:

  • Unit testing
    • There is a limited need for this, but unit tests could be added around the validation of new customers and jobs to ensure those business rules are followed
  • Pagination
    • Currently all jobs/customers are returned. In a real-world situation it could be possible to see much more data, pageable queries would be an area for improvement if performance became a concern.

HBinmore added 4 commits May 18, 2022 18:21
- Db changes to add customer table (INCLUDES MIGRATION)
- Basic controller methods to get single, get all, and create customer
- Listing & viewing customers
- Creating customer
- Nullable customer added to job
- Get job(s) methods expanded to return customer if present
- Added the ability to select a customer when creating a new job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant